Fixed bug in F748: Set Position and Motion #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to make it match the code correctly.
LtRipley36706
approved these changes
Mar 27, 2017
ogmage78
pushed a commit
to ogmage78/ACE
that referenced
this pull request
Mar 28, 2017
Created IF statement to remove Welcome popup box When using this IF statement you can remove the Welcome to this ACE server!\nFor more information visit http://www.acemulator.org. from inside the quotes in the config.json file and the popup box does not appear. Fixed bug in F748: Set Position and Motion (ACEmulator#170) * Fixed bug in F748: Set Position and Motion * Needed to fix the comments Had to make it match the code correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a bug in this code that was keeping me from being able to drop an item.
Fixed alignment problem and cleaned up the ability to report position with the correct flags
I moved and expanded an enum flag list for correct scoping
I put the position flag in the position object and initialized the flags correctly on player create.
Added another signature to Serialize - left the old one for backward compatibility - we may want to look at refactoring this.
Please let me know if you anything that looks wrong. I am still learning. This is more of a plumbing fix. You should not notice anything new or anything new broken :) If this get's merged - I want to start looking at creating mutable objects next.