Adjust Stack Split/Merge Handling #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmriggs
approved these changes
May 16, 2019
Mag-nus
added a commit
to Mag-nus/ACE
that referenced
this pull request
May 20, 2019
Switch back to int to avoid the type casting. We now check to see if amount is <= 0 instead of just == 0 to avoid packet crafting exploits. The additional messages remain. A new logging message has been added for <= 0 events detected.
Mag-nus
added a commit
that referenced
this pull request
May 27, 2019
* Partial #1902 Revert Switch back to int to avoid the type casting. We now check to see if amount is <= 0 instead of just == 0 to avoid packet crafting exploits. The additional messages remain. A new logging message has been added for <= 0 events detected. * Another == 0 check changed to<= 0 * Stack adjustment validation * misc cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.