Add AdjustDungeon to teleports via magic #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmriggs
reviewed
May 17, 2019
| portalRecall.AddAction(targetPlayer, () => | ||
| { | ||
| var teleportDest = new Position(portal.Destination); | ||
| targetPlayer.AdjustDungeon(teleportDest); |
There was a problem hiding this comment.
should this be done in .Teleport(), instead of having all of these calls to it?
i seem to remember .AdjustDungeon() being done in Teleport originally, but im not sure why that was removed...
gmriggs
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.