Added lifestone attunment, @ls recall, and position fixes. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantoms
force-pushed
the
feature-LifestoneUsage
branch
2 times, most recently
from
a00ea41
to
34abe01
Compare
Worked out the log4net problems and changed database logging Testing appveyor Reset debugging Updated changelog Changed Lifestone usage recall to the correct enum
fantoms
force-pushed
the
feature-LifestoneUsage
branch
from
34abe01
to
1530d36
Compare
fantoms
commented
Apr 6, 2017
| @@ -78,8 +84,8 @@ public void AddPreparedStatement<T>(T id, params object[] parameters) | |||
| } | |||
| catch (MySqlException transactionException) | |||
| { | |||
| Console.WriteLine($"An exception occured while commiting a transaction of {queries.Count} queries, a rollback will be performed!"); | |||
| Console.WriteLine($"Exception: {transactionException.Message}"); | |||
| log.Error($"An exception occured while commiting a transaction of {queries.Count} queries, a rollback will be performed!"); | |||
There was a problem hiding this comment.
Should this be set to Error channel? I believe it's more relevant to capture these exceptions as errors, if different logging levels are being utilized.
Mogwai-TheFurry
approved these changes
Apr 6, 2017
| float dy = Math.Abs(landBlockObject.Position.PositionY - session.Player.Location.PositionY); | ||
| float dz = Math.Abs(landBlockObject.Position.PositionZ - session.Player.Location.PositionZ); | ||
|
|
||
| // check if the distance is greater then |
There was a problem hiding this comment.
This should use 3D pythagorean math, not checks on individual axis components. It will work, but it's logically incorrect.
| var objectId = new ObjectGuid(fullId); | ||
|
|
||
| // get the worldobject from the id, if it exists | ||
| AceObject landBlockObject = DatabaseManager.World.GetObjectsByLandblock(session.Player.Location.LandblockId.Landblock).Find(o => o.AceObjectId == objectId.Full); |
There was a problem hiding this comment.
I applaud the effort here. It's the best you could do with what you have. We really just need that action queue - stuff like this isn't going to fly in the long run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also worked out the log4net problems for debugging databases