MovementEvent Action Queue #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mogwai-TheFurry
suggested changes
Apr 11, 2017
Source/ACE/Entity/Player.cs
Outdated
| @@ -663,6 +663,18 @@ public void ActionApplyVisualEffect(PlayScript effect, ObjectGuid objectId) | |||
| AddToActionQueue(action); | |||
| } | |||
|
|
|||
| public void ActionMovementEvent(GeneralMotion motion, ObjectGuid objectId) | |||
There was a problem hiding this comment.
function names like this should usually have a verb. in this case, your verb is "Enqueue". Full method name: "EnqueueActionMovementEvent"
Source/ACE/Entity/Player.cs
Outdated
|
|
||
| // public void MovementEvent(GeneralMotion motion, MotionStance stance, MotionItem item, MotionCommand command, WorldObject sender) | ||
| public void MovementEvent(GeneralMotion motion, WorldObject sender) | ||
| { |
There was a problem hiding this comment.
SendSessionMovementEvent
| public uint ObjectId { get; private set; } | ||
|
|
||
| public uint SecondaryObjectId { get; private set; } | ||
|
|
||
| public GameActionType ActionType { get; private set; } | ||
|
|
There was a problem hiding this comment.
Concerned about the growth of this object. Just something to keep an eye on.
There was a problem hiding this comment.
There's a lot of things we're gonna need queues for, I don't see how this doesn't keep growing :|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally this is merged after #226 if this acceptable for merging.