Creature kill and corpse spawn #238

Lidefeath · 2017-04-13T22:32:21Z

As discussed with fantom, I'll resubmit it as a real PR so everyone can play around with it.
Usage: target drudge, type /smite -> drudge dead and corpse spawns

LtRipley36706

Good stuff!! just adding what I was talking about per our discord discussions yesterday based on my findings this evening

LtRipley36706 · 2017-04-14T07:04:38Z

Source/ACE/Entity/Creature.cs

+            session.Network.EnqueueSend(creatureDeathEvent);
+
+            // 2. step in retail: SoundEvent: sound 48 (HitFlesh1), volume 0,5
+            session.Player.ActionApplySoundEffect(Sound.HitFlesh1, Guid);


Step 2 comes from something else, likely the player getting hit by the drudge, but possibly the drudge getting hit by the player, either way would be handled in another place, not in death

In the pcap I was analyzing that sound effect had the objectID of the drudge. But I am with you that this has to come from executing a combat action.

LtRipley36706 · 2017-04-14T07:04:55Z

Source/ACE/Entity/Creature.cs

+            session.Player.ActionApplySoundEffect(Sound.HitFlesh1, Guid);
+
+            // 3. step in retail: SoundEvent: sound 14 (Wound3), volume 1
+            session.Player.ActionApplySoundEffect(Sound.Wound3, Guid);


Step 3 comes from something else, likely the player getting hit by the drudge, but possibly the drudge getting hit by the player, either way would be handled in another place, not in death

Same as step 2: Found in pcap, but belongs to combat hit

LtRipley36706 · 2017-04-14T07:06:41Z

Source/ACE/Entity/Creature.cs

+            // 4. step in retail: MovementEvent: (Hand-)Combat to Death
+            // TODO: this isn't really working yet, we need more work on the motion stuff
+            GeneralMotion motion1 = new GeneralMotion(MotionStance.Standing, new MotionItem(MotionCommand.Dead));
+            session.Network.EnqueueSend(new GameMessageUpdateMotion(this, session, motion1));


I expect this method to change again after some more refactoring but for now...

change session.Network.EnqueueSend(new GameMessageUpdateMotion(this, session, motion1)); to session.Player.EnqueueMovementEvent(motionDeath, this.Guid);

I renamed motion1 to motionDeath in my coding.

animation fires, sound plays.. drudge dies good.

LtRipley36706 · 2017-04-14T07:08:10Z

Source/ACE/Entity/Creature.cs

+            // 5. step in retail: Play Script to show wound depending on where the last hit was
+            // TODO: this is not showing yet, guess we need to give all the sounds and scripts some time to actually play
+            var effectEvent = new GameMessageScript(Guid, Network.Enum.PlayScript.SplatterMidRightFront);
+            session.Network.EnqueueSend(effectEvent);


Again, I feel like this would be handled by another function tracking hits but maybe the final blow would or should be handled by kill...

LtRipley36706 · 2017-04-14T07:08:31Z

Source/ACE/Entity/Creature.cs

+            session.Network.EnqueueSend(effectEvent);
+
+            // 6. step in retail: UpdatePosition: gotta verify this on more examples
+            // I guess it lowers the z axis, so the corpse isn't hovering in about the midth of a usual drudge


LtRipley36706 · 2017-04-14T07:18:31Z

Source/ACE/Entity/Player.cs

@@ -45,6 +45,11 @@ public sealed class Player : MutableWorldObject
        public bool IsOnline { get; private set; }

        /// <summary>
+        /// ObjectId of the currently selected Target (only players and creatures)
+        /// </summary>
+        public uint SelectedTarget { get; set; }


seems like this would be anything you can target, not just players or creatures

I am not sure if you are right: if you target a creature or player a QueryHealth message is fired with the objectID of the targeted creature or player. If you target an item like a lifestone a QueryHealth message is fired too, but with an objectID of 0. The same happens if you press the ESC key to deselect your target,

Yeah, but does/should the server track it?

I needed the server to track it, so I could issue the smite command to the selected target. In retail there are even messages which lead to store the target as last attacker in the properties of a character

LtRipley36706 · 2017-04-14T07:20:07Z

Source/ACE/Entity/Player.cs

@@ -45,6 +45,11 @@ public sealed class Player : MutableWorldObject
        public bool IsOnline { get; private set; }

        /// <summary>
+        /// ObjectId of the currently selected Target (only players and creatures)
+        /// </summary>
+        public uint SelectedTarget { get; set; }


Also later in Player.cs, I changed the following code in TrackObject:

log.Debug($"Telling {Name} about {worldObject.Name} - {worldObject.Guid.Full.ToString("X")}"); // if (sendUpdate) // Session.Network.EnqueueSend(new GameMessageUpdateObject(worldObject)); // else Session.Network.EnqueueSend(new GameMessageCreateObject(worldObject));

It's not right, but the UpdateObject messages are doing more harm than good at this point and we'll be needing to address this soon to find the right sequence and way for handling this part

LtRipley36706 · 2017-04-14T07:23:27Z

Source/ACE/Entity/Landblock.cs

+                    if (o.Guid.IsCreature())
+                    {
+                        if ((o as Creature).IsAlive)
+                            (wo as Player).TrackObject(o);


smite the drudge in holtburg, logout, don't reset the server, log back in, crash the server.. didn't check into this further.

LtRipley36706 · 2017-04-14T07:24:22Z

Source/ACE/Network/GameEvent/Events/GameEventDeathNotice.cs

+            Writer.WriteString16L(message);
+        }
+    }
+}


You meant add a new line in the message?

files need to end on a new line per code style

LtRipley36706 · 2017-04-14T07:26:30Z

Source/ACE/Factories/CorpseObjectFactory.cs

+
+            // TODO: Find the correct motionstate to create a corpse with. For now only the dead motionstate works 
+            // wo.PhysicsData.CurrentMotionState = new GeneralMotion(MotionStance.Standing);
+            wo.PhysicsData.CurrentMotionState = new GeneralMotion(MotionStance.Standing, new MotionItem(MotionCommand.Dead));


to me this feels like the only way it would ever work

would need to compare pcaps to verify of course

Mogwai-TheFurry · 2017-04-14T13:00:18Z

Source/ACE/Command/Handlers/AdminCommands.cs

-            // TODO: output
+            if (parameters?.Length > 0)
+            {
+                if (parameters[0] == "all")


if you're not going to implement it, don't bother with the special-case logic.

Mogwai-TheFurry · 2017-04-14T13:19:27Z

Source/ACE/Entity/Creature.cs

+            // 8. step in retail: Create Corpse (dead for now - but guess is standing or in combat should be right)
+            // TODO: set text of killer in description
+            var corpse = CorpseObjectFactory.CreateCorpse(this, this.Location);
+            LandblockManager.AddObject(corpse);


you can use a Threading Timer. sleeping a thread that long is a big no-no :)

Mogwai-TheFurry · 2017-04-14T13:19:42Z

Source/ACE/Entity/Creature.cs

+
+            // 9. step in retail: Death Animation of corpse
+            GeneralMotion motion2 = new GeneralMotion(MotionStance.Standing, new MotionItem(MotionCommand.Dead));
+            session.Network.EnqueueSend(new GameMessageUpdateMotion(corpse, session, motion2));            


but if it works, leave it :)

Mogwai-TheFurry · 2017-04-14T13:20:57Z

Source/ACE/Entity/Player.cs

@@ -45,6 +45,11 @@ public sealed class Player : MutableWorldObject
        public bool IsOnline { get; private set; }

        /// <summary>
+        /// ObjectId of the currently selected Target (only players and creatures)
+        /// </summary>
+        public uint SelectedTarget { get; set; }


Yeah, but does/should the server track it?

Lidefeath · 2017-04-15T15:09:00Z

I fixed and improved this according to your suggestions and will submit a new PR. Thanks all for the help!

Lidefeath added 4 commits April 12, 2017 07:19

Working on corpse spawning

8be2937

Model kill and corpse spawn after retail pcaps.

d2f51e9

Merge branch 'master' into creature-kill-corpse

4cf7ab5

Changelog

8e497b3

LtRipley36706 requested changes Apr 14, 2017

View reviewed changes

Mogwai-TheFurry reviewed Apr 14, 2017

View reviewed changes

Lidefeath closed this Apr 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creature kill and corpse spawn #238

Creature kill and corpse spawn #238

Lidefeath commented Apr 13, 2017

LtRipley36706 left a comment

LtRipley36706 Apr 14, 2017

Lidefeath Apr 14, 2017

LtRipley36706 Apr 14, 2017

Lidefeath Apr 14, 2017

LtRipley36706 Apr 14, 2017 •

edited

LtRipley36706 Apr 14, 2017

LtRipley36706 Apr 14, 2017

LtRipley36706 Apr 14, 2017

LtRipley36706 Apr 14, 2017

Lidefeath Apr 14, 2017

Mogwai-TheFurry Apr 14, 2017

Lidefeath Apr 14, 2017

LtRipley36706 Apr 14, 2017

LtRipley36706 Apr 14, 2017

LtRipley36706 Apr 14, 2017

LtRipley36706 Apr 14, 2017

Lidefeath Apr 14, 2017

LtRipley36706 Apr 14, 2017

LtRipley36706 Apr 14, 2017

LtRipley36706 Apr 14, 2017

Mogwai-TheFurry Apr 14, 2017

Mogwai-TheFurry Apr 14, 2017

Mogwai-TheFurry Apr 14, 2017

Mogwai-TheFurry Apr 14, 2017

Lidefeath commented Apr 15, 2017

Creature kill and corpse spawn #238

Creature kill and corpse spawn #238

Conversation

Lidefeath commented Apr 13, 2017

LtRipley36706 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LtRipley36706 Apr 14, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Lidefeath commented Apr 15, 2017

LtRipley36706 Apr 14, 2017 •

edited