Creature kill corpse v2 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… still there for testing.
fantoms
added a commit
to fantoms/ACE
that referenced
this pull request
Apr 17, 2017
…ulator#243. Tests fix for Issue ACEmulator#242
Mogwai-TheFurry
suggested changes
Apr 18, 2017
| // TODO: output | ||
| if (parameters?.Length > 0) | ||
| { | ||
| if (parameters[0] == "all") |
There was a problem hiding this comment.
The more I think about it, the more I don't like having "/smite all" as a thing. Not needed by players, not needed by admins (really), and creates some unnecessary design complications.
Mogwai-TheFurry
added
blocked:Needs rework
blocked:Not needed
and removed
blocked:Not needed
labels
|
I removed the smite command as requested - although I don't see why implementing it was so bad if it's in the client. |
Lidefeath
added a commit
to Lidefeath/ACE
that referenced
this pull request
Apr 18, 2017
Despawn corpses and respawn creatures work. Improved the spawn command in debugcommands.cs. Spawn creatures in landblock from reading the generator data in db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new version of the creature kill and corpse spawning with the smite command. Now the animations work without a sleep command but by introducing delays into the GameActionQueue. More details in the changelog.