Caster update #2451
Caster update #2451
Conversation
Getting changes
sync fork with head repo
…s droprates in clothing
If tier is between 4-6 then a chance for non elemental missile weapon. HarliQ 11/17/19 Tier 6 and up, Only elemental missile weapons are supposed to drop per retail. HarliQ 11/17/19 Added 10% varaiance for Damage Modifier. Full Modifier was rare in retail Added +19 Elemental (like retail) and readjusted odds (odds are approximate, no hard data). HarliQ 11/17/19 Made MeleeDefenseMod appropiate to Bow Reqs. Data is supports 375 wields should go upto +20, however I left them at +18 for now Added Class for finding Epics
…onFactory.cs (no need for it now, and may change the way I was going to do it).
… Corrected by changing to wield req and not tier. Also changed ratio for wield drops in tiers. MinReq=30%, MidReq=50%, MaxReq=20%. I may change this once I get more data from Magnus, to reflect the exact ratio from retail
|
PR isn't really presenting clean. There appears to still be code changes from the Test Loot Generator PR, along with changes that are duplicated in the Missile Loot gen PR. This one should really only have just the two files being touched, IMO. Still gives the appearance of being all inclusive... |
Once the new PR is merged, then those should issues should resolve. This is how I was instructed to do this, per Magnus and Gmriggs. |
|
OK. I guess it is just my OCD acting up, when seeing all of those merge branch commits and incremental change commits from the get go, instead of a clean, single commit ( or very few initial commits ) PR. |
| @@ -23,5 +23,29 @@ public partial class TreasureDeath | |||
| public int MundaneItemMaxAmount { get; set; } | |||
| public int MundaneItemTypeSelectionChances { get; set; } | |||
| public DateTime LastModified { get; set; } | |||
|
|
|||
There was a problem hiding this comment.
going to need to find a different way to do this part, scaffolding will blow this out every time
There was a problem hiding this comment.
yeah my bad, i completely forgot this was a scaffolding generated file
this method should be easily moveable to a static method in another class, or an extension method: deathTreasure.Clone()
Source/ACE.Server/ACE.Server.csproj
Outdated
| @@ -10,6 +10,10 @@ | |||
| <ServerGarbageCollection>true</ServerGarbageCollection> | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <Compile Remove="Factories\TestLootGenerationFactory.cs" /> | |||
There was a problem hiding this comment.
This should not be modifying the .csproj file.
LootFactory CreateCaster refactored. Items now created via wields not tier. Updated values for the correct wields (values are based off of data from Optim and Magnus).
PR has been tested on private server without issue.