Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major restructuring of object heirarchy. please review. #247

Merged
merged 1 commit into from
Apr 18, 2017
Merged

major restructuring of object heirarchy. please review. #247

merged 1 commit into from
Apr 18, 2017

Conversation

Mogwai-TheFurry
Copy link
Contributor

major restructuring of objects. verified login works, and that lifestones/portals appear. can still use lifestones. A lot of plumbing work to be done on new types.

Unfinished / TODO / Known uglies:

  • Update Landblock to use new OnUse / OnCollide methods
  • Remove previous "Use" code (I'm looking at you, Lifestones)
  • Fix/Overhaul CreatureAbility shenanigans in Player/Character/Creature classes. It's a hacky mess right now.

…ones/portals appear. can still use lifestones. A lot of plumbing work to be done on new types.
Copy link
Contributor

@ogmage78 ogmage78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like what you have done here. It lays out a very clean pattern for us to follow. I especially liked how it facilitated the distinction between portals (collideable) and summoned portals (usable).

@ogmage78
Copy link
Contributor

I also really like the container class container -> creature -> player We will be able to do container -> chest.

@Mogwai-TheFurry Mogwai-TheFurry merged commit c3203f9 into ACEmulator:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants