Phase 1 Refactor of Session, NetworkSession, Action handlers #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lidefeath
reviewed
Apr 21, 2017
Source/ACE/Entity/Landblock.cs
Outdated
| Creature cwo = new Creature(c); | ||
| worldObjects.Add(cwo.Guid, cwo); | ||
| // Creature cwo = new Creature(c); | ||
| // worldObjects.Add(cwo.Guid, cwo); |
There was a problem hiding this comment.
You disabled creature spawning here. Is there another place where this is happening now, as I couldn't really find it anywhere else.
There was a problem hiding this comment.
Reverted it. For some reason that section causes an Exception for me, so was easier to comment it out.
…r, added stateful progression of events. Trying to encapsulate logic better. This is lead up to major rebase of how Messages/Actions are handled.
…rked delegate callers to handle that. Now all message handler calls are effectivly an instance function call for Session.
| [GameAction(GameActionType.AllegianceUpdateRequest)] | ||
| private void AllegianceUpdateRequestAction(ClientMessage message) | ||
| { | ||
| var unknown1 = message.Payload.ReadUInt32(); |
There was a problem hiding this comment.
This is bad for the Player class. The Player class, which represents a person at the keyboard playing the game, is now responsible for parsing network Game Actions? Please no.
| public partial class Player | ||
| { | ||
| [GameAction(GameActionType.Suicide)] | ||
| private void CharacterSuicide(ClientMessage message) |
There was a problem hiding this comment.
Well this used to work...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged SocketManager into WorldManager
Made Session inherit from NetworkSession, flattening the model
Moved GameMessage handlers into Session class, partial classes
Moved GameAction handlers into Player class, partial classes
This move makes functionality encapsulated into these classes, allowing a move to fewer public members.
Phase 2 will be to build on WorldObject model to improve queued game actions, broadcast, and action ordering/timing.