Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few portals i did to make sure i understand github ect. #281

Closed
wants to merge 2 commits into from

Conversation

Jyard1
Copy link
Contributor

@Jyard1 Jyard1 commented Apr 24, 2017

Banderling Hovel and Shou-zn settlement portal.

Banderling Hovel and Shou-zn settlement portal.
INSERT INTO `portal_destination` (`weenieClassId`, `cell`, `x`, `y`, `z`, `qx`, `qy`, `qz`, `qw`, `min_lvl`, `max_lvl`) VALUES
(13127, 3578855429, 18.2322, 104.646, 48.564, -0.601667, 0, 0, 0.798747, 0, 0),
(28267, 24772919, 29.6039, -10.1276, 0.01, 1, 0, 0, 0, 10, 0),
('28268', '3663134748', '92.442154', '76.792091', '14.004999', '-0.969302', '0', '0', '-0.245872', '0', '0');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

('28268', '3663134748', '92.442154', '76.792091', '14.004999', '-0.969302', '0', '0', '-0.245872', '0', '0')
remove the single quotes around the numbers

Copy link
Contributor

@Mogwai-TheFurry Mogwai-TheFurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should never have qx rotation in the destination. You should have qz and qw only. Your data points need fixing.

@Mogwai-TheFurry
Copy link
Contributor

Also, you need to put a comment in the changelog to reflect what you did.

@Jyard1
Copy link
Contributor Author

Jyard1 commented Apr 25, 2017

going to merge this one with the other.. closing.

@Jyard1 Jyard1 closed this Apr 25, 2017
@Jyard1 Jyard1 deleted the patch-1 branch April 25, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants