Network layer bug fix, reduction #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when the fragment parser tries to read past the end of the data simplified CryptoSystem removed unused counter from ISAAC simplified client packet CRC verification call stack
|
Can confirm this patch has been running on CE the past couple days, no issues reported with it |
Mag-nus
approved these changes
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed bug allowing a corrupt or malformed packet to crash the server when the fragment parser tries to read past the end of the data
simplified
CryptoSystemremoved unused counter from
ISAACsimplified client packet CRC verification call stack
Tested with full Clumsy suite enabled: passed
Tested with Coldeve, currently active in Coldeve, current pop: 600
Credit goes to Yonneh for simplified
CryptoSystem