Added XpTable class to ACE.DatLoader and removed the JSON Xp files. #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome additional cleanup in the other DatLoader.FileTypes classes.
Mogwai-TheFurry
suggested changes
Apr 25, 2017
| @@ -536,7 +536,8 @@ public QueuedGameAction ExaminationQueuePop() | |||
| public void GrantXp(ulong amount) | |||
| { | |||
| // until we are max level we must make sure that we send | |||
| var chart = DatabaseManager.Charts.GetLevelingXpChart(); | |||
| XpTable xpTable = XpTable.ReadFromDat(); | |||
There was a problem hiding this comment.
These should be read once and cached in a static variable. I'd rather have higher memory requirements than create performance issues of reading from dat files every time somebody clicks the up arrow.
There was a problem hiding this comment.
The XpTable class is already a "singleton" and caches the dat loading. (I learned that from you what I did the CharGen stuff) You had me questioning if this was working, but I threw a breakpoint in there to confirm and it is working as intended.
Mogwai-TheFurry
approved these changes
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some additional cleanup in the other DatLoader.FileTypes classes to make them easier to use.