Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4eyebiped lootgen updates #2 #3160

Closed

Conversation

gmriggs
Copy link
Collaborator

@gmriggs gmriggs commented Aug 23, 2020

Includes Hammer wcids from ACEmulator/ACE-World-16PY-Patches#603

From 4eyebiped: "Weapon damage overhaul and other corrections"

@gmriggs gmriggs requested a review from harliq August 23, 2020 14:58
@gmriggs
Copy link
Collaborator Author

gmriggs commented Aug 23, 2020

Requesting review from @harliq and @ziang4891

};

public static readonly int[,] TwoHandedWeaponDamageTable =
{ // 0|250|300|325|350|370|400|420|430
{ 13, 17, 22, 26, 30, 35, 39, 42, 45 }, // Cleaving
{ 14, 19, 23, 28, 33, 37, 42, 45, 48 } // Spears
{ 13, 20, 23, 27, 30, 33, 39, 42, 45 }, // 0 - Cleaving
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide the data for these changes? You are creating a pretty big gap from 370 to 400 wield Cleavers. That is uncharacteristic of the pattern that Turbine used. Basically the changes from 250-370 wields are in question.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The information you see comes from two sources. Mag-Tools, which lacks a lot of data 370 and below, with the lower tiers being almost non existent. The other source is from a recent mining of pcaps done by morosity. We both compared data, discuss a couple of anomalies and sorted through the numbers. The changes look to be the most accurate to date for both EMUs. Feel free to message me on discord about any of this for further info

new float[] { 2.3f, 2.3f, 2.4f, 2.5f, 2.6f, 2.6f, 2.6f, 2.6f, 2.6f } // Thrown
{ // 0| 250| 270| 290| 315| 335| 360| 375| 385|
new float[] { 2.1f, 2.2f, 2.3f, 2.4f, 2.4f, 2.4f, 2.4f, 2.4f, 2.4f }, // Bow
new float[] { 2.4f, 2.5f, 2.55f, 2.65f, 2.65f, 2.65f, 2.65f, 2.65f, 2.65f }, // Crossbow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to provide specific data for these changes, as I painstakingly verified this data.

@harliq
Copy link
Collaborator

harliq commented Sep 4, 2020

I still do not agree with some of the changes for damage. No hard proof was given for those changes. Just data from others that can not be verified.

@4eyebiped
Copy link

4eyebiped commented Sep 4, 2020

I still do not agree with some of the changes for damage. No hard proof was given for those changes. Just data from others that can not be verified.

To explain further, I first examined the information in Combined_Mag-Tools_Inventory_Loot_Generation.xlsm. I gathered what information was available from there, then I compared it to Morosity’s very recent pcap mining to verify my information and to check for anomalies on both our sides.

You mentioned several issues you have with the changes I presented for two handers. All that information is in the magtools/virindi export. That is my hard proof, which I thought we all have access to and were using? I didn’t need further sources for two handers, though I still compared all information against Morosity’s data. The more sources along with multiple people gathering it in a different way, the better. Seeing as he gathered his data separately and through a different resource, it made me feel more confident in my numbers.

I will list below the number of examples that can be found in the magtools/virindi export to support my numbers, as I fully understand you dismissing Morosity’s data, since you don’t have direct access to it. I do have a link to the raw PCAPs that he used (Which I assume both projects are using but perhaps he has additional ones), but we would have to mine the data ourselves from it. Which I would happily dig through afterwards as I lack coding skills.

30 examples to support 39 damage 400 wield
8 examples to support 33 damage 370 wield
16 examples to support 30 damage 350 wield
5 examples to support 27 damage 325 wield
5 examples to support 23 damage 300 wield
3 examples to support 20 damage 250 wield

If I am somehow misunderstanding you on why you do not accept this data, let me know so we can discuss it. If Combined_Mag-Tools_Inventory_Loot_Generation.xlsm is considered inaccurate, let me know. I got this file from either Hells or OptimShi and was told this is what you guys were using.

EDIT: The original 35 damage currently listed for 370 wield, there isn't even 1 example of that in the magtool export.

@gmriggs gmriggs closed this Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants