Add support to EmoteManager for ResistSpell emote category #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmriggs
reviewed
Aug 26, 2020
| @@ -339,6 +339,8 @@ public bool TryResistSpell(WorldObject target, Spell spell, WorldObject caster = | |||
| player.Session.Network.EnqueueSend(new GameMessageSystemChat($"{targetCreature.Name} resists your spell", ChatMessageType.Magic)); | |||
|
|
|||
| player.Session.Network.EnqueueSend(new GameMessageSound(player.Guid, Sound.ResistSpell, 1.0f)); | |||
|
|
|||
| targetCreature.EmoteManager.OnResistSpell(player); | |||
There was a problem hiding this comment.
should be moved down to the end of if (resisted)
if a CombatPet casts a spell on a monster, and the spell is resisted, the monster should still be calling EmoteManager.OnResistSpell(combatPet)
There was a problem hiding this comment.
er since combat pets don't cast spells, probably not the best example... but if we have monsters attacking monsters from factions eventually, the concept is still sound... this shouldn't be dependent on the attacker being a player
gmriggs
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.