Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verification for AugmentationCost #3170

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Conversation

gmriggs
Copy link
Collaborator

@gmriggs gmriggs commented Aug 26, 2020

AugmentationDevice.VerifyRequirements() was using AugmentationCost ?? 0, and the rest of the functions were using AugmentationCost directly

This had the effect of letting an AugmentationDevice w/ missing/bad data go through, resulting in undefined behavior afterwards, such as setting AvailableExperience to null

Adding check to AugmentationDevice.VerifyRequirements() to ensure AugmentationCost is not null

@gmriggs gmriggs merged commit 7f29993 into ACEmulator:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants