add verification for AugmentationCost #3170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AugmentationDevice.VerifyRequirements() was using AugmentationCost ?? 0, and the rest of the functions were using AugmentationCost directly
This had the effect of letting an AugmentationDevice w/ missing/bad data go through, resulting in undefined behavior afterwards, such as setting AvailableExperience to null
Adding check to AugmentationDevice.VerifyRequirements() to ensure AugmentationCost is not null