adding PetDevice and EncapsulatedSpirit to updated loot system #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…difficulty, damage variance, weapondefense, and weaponoffense
…lementalDamageBonus, WieldRequirements, and WeaponDefense
…nMod, ElementalDamageMod, WieldRequirements, and WeaponDefense
# Conflicts: # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/finesse_axe.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/finesse_dagger_ms.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/finesse_mace_jitte.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/finesse_spear.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/finesse_sword.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/finesse_unarmed.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_axe.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_dagger_ms.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_axe.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_dagger.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_dagger_ms.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_mace.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_mace_jitte.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_spear.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_staff.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_sword.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_sword_ms.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_finesse_unarmed.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_mace.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/light_staff.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/two_handed_cleaver.txt # Source/ACE.Server/Factories/Entity/Mutations/Damage_WieldDifficulty_DamageVariance/two_handed_mace.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_axe.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_dagger.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_dagger_ms.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_mace.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_mace_jitte.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_spear.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_staff.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_sword.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_sword_ms.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/finesse_unarmed.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/light_axe.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/light_dagger.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/light_dagger_ms.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/light_mace.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/light_spear.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/light_staff.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/light_sword.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/light_unarmed.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/two_handed_axe.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/two_handed_mace.txt # Source/ACE.Server/Factories/Entity/Mutations/MeleeWeapons/Damage_WieldDifficulty_DamageVariance/two_handed_sword.txt # Source/ACE.Server/Factories/Enum/TreasureWeaponType.cs # Source/ACE.Server/Factories/LootGenerationFactory_Melee.cs
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory_Magic.cs # Source/ACE.Server/Factories/LootGenerationFactory_Melee.cs # Source/ACE.Server/Factories/LootGenerationFactory_Missile.cs
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory_Magic.cs # Source/ACE.Server/Factories/LootGenerationFactory_Missile.cs
# Conflicts: # Source/ACE.Server/Factories/Enum/TreasureWeaponType.cs # Source/ACE.Server/Factories/LootGenerationFactory.cs # Source/ACE.Server/Factories/LootGenerationFactory_Melee.cs # Source/ACE.Server/Factories/LootGenerationFactory_Missile.cs
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory_Magic.cs
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory.cs # Source/ACE.Server/Factories/LootGenerationFactory_Magic.cs
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory.cs # Source/ACE.Server/Factories/LootGenerationFactory_Magic.cs
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory.cs
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory.cs # Source/ACE.Server/Factories/LootGenerationFactory_Magic.cs
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory_Magic.cs
…ity mod to more rolls
LtRipley36706
previously approved these changes
Oct 1, 2020
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory.cs # Source/ACE.Server/Factories/LootGenerationFactory_Magic.cs
# Conflicts: # Source/ACE.Server/Factories/LootGenerationFactory.cs
LtRipley36706
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in terms of where PetDevices and EncapsulatedSpirits were in the retail loot table structure, some surprising things were found from analysis of the magloot corpse logs
at first i assumed these would not be in the top-level tables, and they would be sub-categories of something else, like Gems. however, no strong correlations were found that matched up with this.
for PetDevices, they appeared to be in the non-magical item profile table only. if a creature didn't drop any non-magical items, then it didn't drop any PetDevices.
for encapsulated spirit, since it is an unmutated item, it seems like it would be prime for MundaneItems. however, it appeared to be a MagicalItem. if a creature didn't drop any non-magical or mundane items, it still appeared to drop EncapsulatedSpirits.
PetDevices were found to drop at roughly the same rate as the weapons and armor, in the ItemProfile tables
EncapsulatedSpirits were found to drop at roughly 0.5% rate in the MagicalItem profile tables