Send current attacker message to client. #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send the current attacker message to the client so that the client can use the last attack keyboard shortcut to select the last attacker. Note that these will be sent often when there are multiple attackers. The message should only be sent when the attacker changes
|
I seems it might be the case that this message will be sent when a projectile is fired from a creature, rather than if/when it hits a player. That would be wrong. |
This is incorrect. I cannot currently find a place to issue this message without sprikling if statements around the code base. .e.g TryResistSpell should sometimes issue the message, as well as many other places. There doesn't a appear to be a (single)place / callback to capture an incoming attack on a creature/player |
jspashett
force-pushed
the
send_last_attacker_msg_to_client
branch
2 times, most recently
from
324c8c7
to
bfb75a3
Compare
jspashett
force-pushed
the
send_last_attacker_msg_to_client
branch
from
bfb75a3
to
875d65c
Compare
gmriggs
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the current attacker message to the client so that the client can
use the last attack keyboard shortcut to select the last attacker.
Note that these will be sent often when there are multiple attackers.
The message should only be sent when the attacker changes