Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to ensure players are wielding allowable weapon combos #3660

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Check to ensure players are wielding allowable weapon combos #3660

merged 3 commits into from
Aug 27, 2021

Conversation

OptimShi
Copy link
Collaborator

Will prevent players from entering into any weapon wield combos they should not be able to.

Will also prevent players from entering combat if they have an illegal weapon set up (they will need to remove the illegal set up prior to entering combat/magic mode). This should be enough, in theory, to force players with illegal combinations to stop using them and the first part will prevent them doing it again.

gmriggs
gmriggs previously approved these changes Aug 26, 2021
@gmriggs
Copy link
Collaborator

gmriggs commented Aug 26, 2021

log messages?

@OptimShi
Copy link
Collaborator Author

I've added logging, and there are some legit ways the client will allow for these things to happen, which is why I left the logs as "Warn". e.g. equip a bow, and try to equip a left-hand-tethered melee weapon, and the client will "allow" it (but ACE, logically, blocks it...it just now generates a Warning)

@LtRipley36706 LtRipley36706 merged commit 7bdf325 into ACEmulator:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants