Update BasePropertyDesc.cs #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LtRipley36706
commented
Apr 21, 2023
| @@ -36,7 +36,7 @@ public class BasePropertyDesc : IUnpackable | |||
| PropertyInheritanceType m_inheritanceType; | |||
| PropertyDatFileType m_datFileType; | |||
| PropertyPropagationType m_propagationType; | |||
| PropertyCachingType m_cachingType; | |||
| //PropertyCachingType m_cachingType; | |||
There was a problem hiding this comment.
@OptimShi This variable was never assigned a value, was that missed in Unpack somewhere?
There was a problem hiding this comment.
Honestly, so many of these properties/var names were just guessing based on the class details in the PDB that cachingType entry could been any one of those "bool" values, or it could be a run-time value (and I'm sure some of those bool var names are mislabled/flat out wrong, too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up compiler warnings