Inventory saving #404
Closed
Inventory saving #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some issues with this for sure.. its genric. but it saves inventory.. another db model issue is a much bigger issue.
|
Don't Merge, just to show the db deadlock problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to save inventory, no load..
But this shows us a bigger issue in our data model.
There also a rig job in here to allow up to 20 transactions conflicts before failing but there no transaction order, so its not the greatest method and could result in saved operations happening out of order due to deadlock failure on the database.
Overall there is a bigger issue in our data model that needs addressed.
This PR is just to allow anyone to see it live if they remove the generic error handling I put in to make this not crash ACE.