Improve sphere heap usage #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several of the functions in Sphere take parameters that were not used. This PR creates overloads that retain the existing signatures, marks them obsolete, and removes the unused parameters from the core function. GetHashCode is optimized FindTimeOfCollision is marked Static
Pass Center and Radius to static functions as parameters instead of instantiating a new Sphere on the heap and passing that through the code. Reference: https://learn.microsoft.com/en-us/dotnet/csharp/advanced-topics/performance/
|
This also keeps the existing public API in tact |
LtRipley36706
previously approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass Center and Radius to static functions as parameters instead of instantiating a new Sphere on the heap and passing that through the code.
Reference: https://learn.microsoft.com/en-us/dotnet/csharp/advanced-topics/performance/
This is built on top of the improve stack PR.