Barber #448
Barber #448
Conversation
…t for legacy reasons no longer needed)
|
tried it out, very cool |
Source/ACE/Entity/Player.cs
Outdated
| { | ||
| // Read the payload sent from the client... | ||
| PaletteGuid = message.Payload.ReadUInt32(); | ||
| Character.HeadObject = message.Payload.ReadUInt32(); |
There was a problem hiding this comment.
These operations modify the Player (through the character). Therefore they need to be run as part of the Player's Action's. Do this through an ActionChain (just put the entire thing inside an ActionChain).
| const uint EmpyreanFemaleMotionDID = 0x0900020Du; | ||
|
|
||
| // We will use this function to get the current player's appearance values. | ||
| AceCharacter characterClone = (AceCharacter)Session.Player.GetAceObject(); |
There was a problem hiding this comment.
This accesses the player. If the player is modified while its being cloned it may crash the server. Put this inside an ActionChain to mitigate that issue.
|
I moved the Barber functions into an ActionChain, as requested. |
| @@ -13,7 +7,9 @@ public static class GameActionFinishBarber | |||
| [GameAction(GameActionType.FinishBarber)] | |||
| public static void Handle(ClientMessage message, Session session) | |||
| { | |||
| session.Player.HandleActionFinishBarber(message); | |||
| ActionChain chain = new ActionChain(); | |||
| chain.AddAction(session.Player, () => session.Player.HandleActionFinishBarber(message)); | |||
There was a problem hiding this comment.
I would prefer that the action chain is within HandleActionFInishBarber (HandleAction indicates that the function is safe to call from outside of the player's action context). I wont block the PR over it.
There was a problem hiding this comment.
I will adjust this, then. Because no one, including myself, will ever go back and do it later! Hold off on pushing, please.
Added "@barbershop" debug command and corresponding functionality to load the interface, and save and apply settings.
Changed some CharGen types that were ushort to uints. (They were short for legacy reasons no longer needed)
Not sure if the HandleActionFinishBarber() function is the "correct" method, so please feel free to point out what I may not be doing the "proper way".