Added npcLooksLikeObject option in appraisal response #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
OptimShi
commented
Jul 16, 2017
OptimShi
commented
- Added npcLooksLikeObject option in appraisal response (Note that no objects in ACE_World are currently set with this bool property)
- Replaced some "unknown" bitfields with proper variable names in PlayerDescription.
ddevec
suggested changes
Jul 17, 2017
| @@ -144,7 +144,9 @@ public GameEventIdentifyObjectResponse(Session session, WorldObject obj) | |||
| flags |= IdentifyResponseFlags.StringStatsTable; | |||
| } | |||
|
|
|||
| if (obj.ItemType == ItemType.Creature) | |||
| // if PropertyPool.NpcLooksLikeObject == true, do not treat as creature data | |||
| var npcLooksLikeObject = propertiesBool.FirstOrDefault(x => x.PropertyId == (uint)PropertyBool.NpcLooksLikeObject)?.PropertyValue; | |||
There was a problem hiding this comment.
Could you make this a property of WorldObject/AceObject, instead of reading it directly from propertiesBool? In general we don't want to mess with properties outside of those classes (with rare exceptions -- like when we have to wholesale send them to the client).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.