Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: WorldObject Reorganization + more #468

Closed
wants to merge 9 commits into from

Conversation

LtRipley36706
Copy link
Member

  • Reorganized folder structure for WorldObject and sub objects.
  • Move chat to be handled by Player.
  • Set up local chat to be landblock ranged.
  • Wired up emotes and soul emotes, also landblock ranged.
  • Moved ID functionality to be handled within WorldObject.
  • Added PK Altar object.

@OptimShi There's some issues with the SetupModel and PK Altar objects. Would like your input on what is going on.. I swapped in a lifestone ID to let me progress through the code to test further but if you bring the real id back in, you'll find it crashes on reading.

Copy link
Contributor

@Mogwai-TheFurry Mogwai-TheFurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial Review: I have to disagree with the subfolder overuse. StyleCop should be failing the build over the mismatch between namespaces and directory structures anyway.

@Mogwai-TheFurry
Copy link
Contributor

Also, in general, this feels like it should have been multiple PRs. You're jamming a lot of work into 1 PR rather unnecessarily, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants