Minor changes to Book weenie #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would this not cause a conflict if I actually added an inscription to a book item? |
|
I wouldn't think so. They are the same data, see wcid 3949 |
|
What if I write in a Parchment (wcid 36), then give it to someone who adds an inscription? (Note that the handful of prewritten books I quickly checked were not inscribable, but blank ones are) |
|
In that case from a GameEventBookDataResponse perspective: inscription, authorId, authorName would reflect whomever inscribed the book, and each GameEventBookPageDataResponse would still contain whomever wrote each page |
Mogwai-TheFurry
suggested changes
Aug 11, 2017
| @@ -29,7 +26,7 @@ public GameEventBookDataResponse(Session session, uint bookID, uint maxPages, Li | |||
| if (session.Player.IsAdmin) | |||
| Writer.WriteString16L(pageData[i].AuthorAccount); | |||
| else | |||
| Writer.WriteString16L(""); | |||
| Writer.WriteString16L("beer good"); | |||
There was a problem hiding this comment.
this is what retail did when masking output, see pcaps
| @@ -16,7 +15,7 @@ public GameEventBookPageDataResponse(Session session, uint bookID, PageData page | |||
| if (session.Player.IsAdmin) | |||
| Writer.WriteString16L(pageData.AuthorAccount); | |||
| else | |||
| Writer.WriteString16L(""); | |||
| Writer.WriteString16L("Password is cheese"); | |||
There was a problem hiding this comment.
this is what retail did when masking output, see pcaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.