Movement Updates #517
Merged
Movement Updates #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
OptimShi
commented
Oct 2, 2017
OptimShi
commented
- Changed MotionCommand and MotionState enums to full uint instead of short and adjusted the movement serializing functions to work with these changes.
- Fixed bug when leaving CombatMode with no ammunition equipped (e.g. melee or magic mode)
- Added "acecommands" tip to console start up
ddevec
approved these changes
Oct 2, 2017
| OffhandPunchSlowHigh, | ||
| OffhandPunchSlowMed, | ||
| OffhandPunchSlowLow | ||
| Invalid = 0x0, |
There was a problem hiding this comment.
Could you use Og's enum value alignment plugin, so we don't get another PR where we have an entire file rewritten over alignment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.