Fix to Value and Burden #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Oct 20, 2017
ghost
commented
- Created WO.StackUnitValue and WO.StackUnitBurden to be initialized by Weenie.{Value,EncumbranceVal}, with builtin null to zero initialization
- Moved WorldObject value and encumbrance calculations down to the WorldObject class, based upon WO.StackUnitValue and WO.StackUnitBurden vs WO.StackSize
| @@ -215,11 +215,15 @@ public void BuyValidateTransaction(ObjectGuid vendorid, List<ItemProfile> items, | |||
| foreach (WorldObject wo in uqlist) | |||
| { | |||
| goldcost = goldcost + (uint)Math.Ceiling(SellRate * (wo.Value ?? 0) * (wo.StackSize ?? 1) - 0.1); | |||
| wo.Value = wo.Value; // Also set the stack's value for unique items, using the builtin WO calculations | |||
There was a problem hiding this comment.
I find this sorta odd that these lines are required.. i would think it should have auto updated the value based on on the getter.. maybe something else is needed though..
There was a problem hiding this comment.
Yes, I tested it without these lines present; however, the value and burden of the items, regardless of stack count, didn't set themselves correctly, until the stack was manipulated. I am wondering maybe item examine is one of the processes that acts upon the AO, instead of the WO, as you mentioned at one point.
LtRipley36706
previously approved these changes
Oct 21, 2017
ghost
dismissed
LtRipley36706
approved these changes
Oct 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.