Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coin value and pickup of stack-able items from landblock #544

Merged
merged 5 commits into from Oct 23, 2017
Merged

Fix coin value and pickup of stack-able items from landblock #544

merged 5 commits into from Oct 23, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2017

  • Add the initial set of CoinValue in Container.cs to the value of contained Coins
  • Modified item move, drop, and pickup methods to account for Pyreal changes, using StackOverflow's UpdateCurrencyClientCalculations();

@ghost
Copy link
Author

ghost commented Oct 22, 2017

Tested splitting Pyreals into multiple stacks of varying sizes and merging stacks back together. Tested moving between main pack and sub-packs. Tested putting pyreals into sub-packs and dropping sub-packs. CoinValue updates correctly. Dropping Pyreal stacks also update CoinValue correctly. Pickup of unsplit stacks works. However, pickup of stacks of anything that have been split don't work, so cannot fully test Pyreal pickup.

@ghost ghost changed the title Fix coin value Fix coin value and pickup of stack-able items from landblock Oct 22, 2017
@ghost
Copy link
Author

ghost commented Oct 22, 2017

If a stack-able item is picked up and no same items exist in inventory, HandleActionPutItemInContainer() method is called. If a same item already exists in inventory, HandleActionStackableMerge() is called. Found by debugging. Added the pickup code with a !HasItem check at the beginning of HandleActionStackableMerge().

@Mogwai-TheFurry Mogwai-TheFurry merged commit 91e8853 into ACEmulator:master Oct 23, 2017
@ghost ghost deleted the FixCoinValue branch March 11, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants