EquipTest Updates #568
Merged
EquipTest Updates #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddevec
previously approved these changes
Nov 21, 2017
| @@ -18,8 +18,8 @@ namespace ACE.Command.Handlers | |||
| { | |||
| internal enum TestWeenieClassIds : uint | |||
| { | |||
| Pants = 120, | |||
| Tunic = 134, | |||
| Pants = 120, | |||
There was a problem hiding this comment.
I don't understand why you shifted these to non indented. We've been keeping the assignments aligned on enums, I dislike the inconsistency this adds.
There was a problem hiding this comment.
I didn't change this purposefully, I think Visual Studio must've made this change for me when I did something. Weird. Fixed it, anyways.
There was a problem hiding this comment.
VS has been changing this automatically for me as well, if you use the CTRL+K and then CTRL+D shortcut, it will show you the same results...
ddevec
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed EquipTest debug command to utilize the index of a clothing table item and added an optional shade parameter