Tier 1 loot #582
Closed
Tier 1 loot #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP Tier 1 loot, new class definitions for missing loot, change in commandHandler, etc.
ghost
reviewed
Dec 28, 2017
| default: | ||
| return new GenericObject(aceO); | ||
| } | ||
| } | ||
|
|
||
| public static WorldObject CreateCorpse(Creature cs) | ||
| { | ||
| ////Console.WriteLine("Inside CreateCorpse"); |
There was a problem hiding this comment.
Corpse creation should probably be moved to its own WO class that is derived from Container, instead of being a method within the WorldObjectFactory class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP Tier 1 loot, new classes for missing loot item, additions to AceObject and WorldObject for variables that needed to be added, command added in commandHandler, etc. Much more work needs to be done to added all the necessary variables to WorldObject.
This should be discussed. I feel that my coding skills may not be on par with most others. I felt the million if/else statements and rnd numbers was excessive, but didn't know how else to do it since all items had different ranges for their stats, etc.