Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateEnchantment/Gem OnUse #602

Closed
wants to merge 3 commits into from
Closed

UpdateEnchantment/Gem OnUse #602

wants to merge 3 commits into from

Conversation

dgatewood
Copy link
Collaborator

I used TortoiseGit to create branch/master. I tried it by git commands only, but it kept telling me no such git directory... Checked it multiple times. I hope I am getting close with Git in general.

Reworked GameEventMagicUpdateEnchantment. The way it was currently trying to pack spell data was garbling things up and the packet no longer matched a retail packet. Once I rewrote it, it now matches retail and also shows all spells in use in the active spell tab in the top left corner, with time remaining(client side). This will be implemented server side soon.

To demonstrate this, I implemented non contract OnUse for gems. You can use Blackmoor's Favor, or the two gems that are available for sale at the gem shop in Holtburg.

@dgatewood
Copy link
Collaborator Author

I will change this later on tonight and fix the appveyor issues. Didn't check it last night before bed

@spazmodica
Copy link
Contributor

As this feature is for the Gem to be casting the spell, GameEventMagicUpdateEnchantment need to also have a casterGuid parameter to have the Gem's guid vs the player guid vs another player's guid who is casting the spell.

Message for using Blackmoon Gem is "The gem casts Blackmoor�s Favor on yo".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants