-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bolt, Streak and Arc updates #787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CreateWorldObject(), in WorldObjectFactory.cs, doesn't need to have anymore overrides created to pass in a spellId to the SpellProjectile class, as it is already available as a public class variable via public uint SpellId { get => spellId; set => spellId = value; }
See the scope of what is being accomplished with change
Probably, would be a good idea to change the SpellID class variable, in SpellProjectile, to private, as now it shouldn't need to be publicly accessible outside the class. However, I won't block the merger. |
I've reverted the world object factory changes and moved some code into a setup function. |
Various bits of code have been added to make the existing spells line up with retail data and lay the groundwork for other spells. There is still more research to do but this is a step closer to retail based on the data I have gathered so far.
I am not sure if the code I added to WorldObjectFactory.cs is the best way to get the spell ID into the constructor (seems like one of the CreateWorldObject functions could be removed/integrated).
I had to add some code to be able to override some PhysicsDescription fields. I did a couple of searches through the pcaps and the fields that I set to false by default don't seem to have been used so I don't believe this will cause any problems.