Creating salvage from items... #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created GameActionCreateTinkeringTool Added HandleTinkeringTool Formula for value is as stated on wiki, though amount salvaged was not found and done from memory where you could salvage 110% from a fully buffed salvage skill. This can be changed if an exact formula presents itself.
ghost
suggested changes
May 19, 2018
| {77, 21080} | ||
| }; | ||
| //CreatureSkill skill = GetCreatureSkill(Skill.Salvaging); | ||
| double salvageSkill = (double)GetCreatureSkill(Skill.Salvaging).Current; |
There was a problem hiding this comment.
The skill check used any one of the different tinkering skills or the salvaging skill itself, whichever was higher, for any of the skill checks used. Confirmed with the Game gurus on the Development channel.
gmriggs
approved these changes
May 19, 2018
|
Basics tested, looks good to me |
ghost
approved these changes
May 19, 2018
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created GameActionCreateTinkeringTool
Added HandleTinkeringTool
Formula for value is as stated on wiki, though amount salvaged was not found and done from memory where you could salvage 110% from a fully buffed salvage skill. This can be changed if an exact formula presents itself.