Various missile combat fixes/additions #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Slushnas
commented
May 25, 2018
Slushnas
commented
- Renamed GameMessageRemoveObject to GameMessageDeleteObject to avoid confusion with other messages.
- Renamed TryDestroyFromInventoryWithNetworking() to TryRemoveFromInventoryWithNetworking() as that function sends InventoryRemoveObject messages.
- Cleaned up some stack merging code and added support for merging missile ammo to currently equipped ammo.
- Added the ability to set the stacksize of spawned items created with the /ci command.
- Fix for observed players improperly playing last combat mode animation when moving.
- Fixed missile ammo appearing in players hands on login.
- Fixed arrows being fired after switching to peace mode.
- Added ammo usage to player missile attacks.
- Added damageSource parameter to damage functions to better support edge cases.
- Various other minor tweaks to bring sent game messages more in line with retail pcaps.
…onfusion with other messages. Renamed TryDestroyFromInventoryWithNetworking() to TryRemoveFromInventoryWithNetworking() as that function sends InventoryRemoveObject messages. Cleaned up some stack merging code and added support for merging missile ammo to currently equipped ammo.
Various other minor tweaks to bring message in line with retail pcaps. Added ammo usage to player missile attacks.
LtRipley36706
previously approved these changes
May 25, 2018
gmriggs
approved these changes
May 25, 2018
LtRipley36706
approved these changes
May 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.