Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spells and a couple of other fixes #836

Merged
3 commits merged into from Jul 2, 2018
Merged

Add spells and a couple of other fixes #836

3 commits merged into from Jul 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2018

  • Modify LearnSpellsInBulk() to use an uint array of player allowed spellIDs
  • Remove extra /addspell in DebugCommands, leaving renamed command in AdminCommands : use continue to use /addspell ( renamed to remove ambiguity about what is being added )
  • Fix NPK vs other players, in regards to harmful spells

gmriggs
gmriggs approved these changes Jul 2, 2018
View reviewed changes
Copy link
Collaborator

@gmriggs gmriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@ghost ghost merged commit 8f8c2c4 into ACEmulator:master Jul 2, 2018
@ghost ghost deleted the AddSpellsFix branch July 4, 2018 19:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmriggs @ziang4891