Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted Magic code :: WIP :: Testing needed before merge #846

Merged
5 commits merged into from Jul 6, 2018
Merged

Adjusted Magic code :: WIP :: Testing needed before merge #846

5 commits merged into from Jul 6, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 5, 2018

-Rearranged code flow to remove some redundant code
-Aligned Magic damage application with Physical damage
-Added Crit and War skill bonus

@ghost ghost changed the title Adjusted Magic code Adjusted Magic code :: WIP :: Please test Jul 5, 2018
@ghost ghost changed the title Adjusted Magic code :: WIP :: Please test Adjusted Magic code :: WIP :: Testing needed before merge Jul 5, 2018
gmriggs
gmriggs approved these changes Jul 5, 2018
View reviewed changes
Copy link
Collaborator

@gmriggs gmriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, War Magic damage bonus looks good for this version

Further discussions for pcap analysis and curve fitting to determine exact algorithm

@ghost ghost merged commit a8680f9 into ACEmulator:master Jul 6, 2018
@ghost ghost deleted the Magic15.0 branch July 7, 2018 16:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmriggs @ziang4891