persistent tracking of item affectance #857
Conversation
item affectance is restored at Player.EnterWorld
|
Tested, functionality worked as expected Before patching, I logged in with a character who had a magical item already equipped, and verified that the mana was not being depleted (pre-patch) Still pre-patch, I dequipped and re-equipped the sword, and verified that the mana was indeed being depleted after re-equipping. I also noticed that equipping magic items instantly used 1 mana upon wielding, not sure if that is intended / matches retail? After patching, I logged in with the character while they had the magic sword already equipped, and the mana started ticking properly. The spells for the wielded item also appeared in the player's enchantments properly The 'IsAffecting' nomenclanture seems a bit non-standard to me (IsActivated?) but that is just a personal preference Nice job with this patch, it really makes things feel more consistent! |
|
Thanks for the testing and critique! If I remember correctly retail did have items burn 1 point of mana immediately upon equipping (and successfully activating) it. I actually went and changed ACE to match that pattern (mana stone PR). Hopefully the "affecting" nomenclature doesn't collide with any concepts in the questing systems. maybe it was for questing, and "hot" or something else is actually for this concept, we will see. I came up with "activated" in the mana stone PR because there is no property with that name and I needed something non-persistent and unique to hold out until the persistence PR. "affecting" is part of the WorldObject property lists which is why I chose it for persistence, a guess that it's the correct one as there are a few others that have plausibly compatible names. |
added null check for emote tells fixed bug causing crash when using the /buff command
…sent to the client and in turn causing inconsistent behaviors in the client enchantment list and player stats
ghost
merged commit 
item affectance is restored at Player.EnterWorld