Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework AppraisalInfo for Enchants #869

Merged
4 commits merged into from Jul 13, 2018
Merged

Rework AppraisalInfo for Enchants #869

4 commits merged into from Jul 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2018 •
edited by ghost

Rework AppraisalInfo to differentiate between intrinsic spells and applied spells

  • "spellbook" data sent in AppraisalInfo packet uses highest bit of uint to indicated whether intrinsic spell of item or applied enchant
  • WeenieType.Cothing enchants are applied to the item
  • Account for debuffs applied to wielded weapons
  • Enchants applied to armor affecting armor stats fixed to display correctly

image

gmriggs
gmriggs previously approved these changes Jul 12, 2018
View reviewed changes
@ghost ghost changed the title WIP : Rework AppraisalInfo for Enchants : Do Not Merge Rework AppraisalInfo for Enchants Jul 13, 2018
@ghost ghost merged commit d18110f into ACEmulator:master Jul 13, 2018
@ghost ghost deleted the ItemSpells4 branch July 16, 2018 15:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmriggs @ziang4891