Delete Invoice RPC method

[tim2CF]

Would be useful to have deleteinvoice RPC method (opposite to createinvoice) to be able to cleanup expired invoices

[t-bast]

If we do it that way, this RPC should ensure it only deletes expired invoices.
The RPC could also have an option to say "delete all expired invoices".

I think an even more useful feature would be to automatically run a task every X hours (configurable in eclair.conf) that deletes all expired invoices from the DB. Users should be able to disable this if they want to keep their full history (for example by setting the frequency of these runs to -1 - or something cleaner like a separate bool). It should probably also run when starting the node (if enabled).

[t-bast]

@dpad85 do you know if eclair-mobile / phoenix already have that kind of clean-up implemented? Would they benefit from it?

[dpad85]

Neither eclair mobile or phoenix have implemented such a feature, but it could be useful indeed.

[t-bast]

Note that this issue should probably be done after #1640

[tim2CF]

Thanks, Bastien!

[tompro]

So reading this thread, I am not quite sure whether it should be a scheduled job with an enabler flag, an exposed endpoint or both?

[tim2CF]

I'm not familiar with internal Eclair architecture, but it feels that there might be 2 cases

• There are no other API methods where expired invoices might be involved, then it feels more like internal feature ans should be enabled by flag
• There are other API methods where expired invoices might be involved, then invoice removing should be completely in user's control through API method

[t-bast]

So reading this thread, I am not quite sure whether it should be a scheduled job with an enabler flag, an exposed endpoint or both?

I think both would be useful (and should be separate PRs).
Cleaning up old expired invoices automatically always makes sense.
Choosing the delete a specific invoice (even if it's not expired) because you messed up something with it also makes sense.

[t-bast]

Done in #1984