Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cancelinvoice API #1916

Closed
Kukks opened this issue Aug 19, 2021 · 3 comments
Closed

Add cancelinvoice API #1916

Kukks opened this issue Aug 19, 2021 · 3 comments

Comments

@Kukks
Copy link
Contributor

Kukks commented Aug 19, 2021

A cancel invoice API would be great to be able to reject payments to invoices you no longer want paid.
@t-bast
Copy link
Member

t-bast commented Aug 23, 2021

This is a duplicate of #1510

@t-bast t-bast closed this as completed Aug 23, 2021
@akumaigorodski
Copy link
Contributor

I'm not sure it's a duplicate, what's desired here is to delete a not yet expired invoice.

@t-bast
Copy link
Member

t-bast commented Aug 23, 2021 •
edited
Loading

IMO a future deleteinvoice RPC should allow deleting non-expired invoices as well. The only case where it should reject the delete request is if the invoice has been paid.

We shouldn't have two distinct RPCs for such related scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kukks @akumaigorodski @t-bast