Update anchor outputs feerate tolerance #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent unwanted channel closure. This can be unsafe in a high fee environment if the commit tx is below the propagation threshold. However, even when we discover it it's too late anyway, so our only option is to wait for package relay to save the day.
t-bast
force-pushed
the
anchor-outputs-feerate-tolerance
branch
from
0fb1909
to
4f9fbb8
Compare
We lift the limit configured by the node operator when it is below the network propagation threshold.
t-bast
force-pushed
the
anchor-outputs-feerate-tolerance
branch
from
4f9fbb8
to
a346e24
Compare
pm47
reviewed
Oct 4, 2021
pm47
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow any feerate when we're fundee and are using anchor outputs: this will completely prevent unwanted channel closure.
However this can be unsafe in a high fee environment if the commit tx is below the propagation threshold.
It could be argued that when we discover it it's too late anyway, so our only option is to wait for package relay to save the day.
But I feel a bit uneasy with a completely unbounded restriction on the lower bound...
Shall we keep the check on the lower bound until package relay lands or is it useless?