Variable size for trampoline onion #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of trampoline onions was fixed at 400 bytes. We remove this limit, allowing larger trampoline onions when necessary. For backward compatibility, anything that used to fit in a 400 bytes onion still uses a 400 bytes onion (even if it could fit in less). Payments with large metadata that would fail because of the 400 bytes limit are now possible and the onion uses exactly the size that's needed, nothing more, nothing less. The size of the trampoline onion is still constrained by the size of the standard onion (1300 bytes).
We don't need to keep creating 400-bytes trampoline payloads, as nobody is using eclair to _send_ trampoline payments, only to relay them, and at that stage it is backwards-compatible to support smaller and bigger onion sizes.
t-bast
reviewed
Jan 12, 2024
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/PaymentOnion.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/OnionRouting.scala
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/payment/PaymentPacketSpec.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of trampoline onions was fixed at 400 bytes. We remove this limit, allowing larger trampoline onions when necessary. For backward compatibility, anything that used to fit in a 400 bytes onion still uses a 400 bytes onion (even if it could fit in less). Payments with large metadata that would fail because of the 400 bytes limit are now possible and the onion uses exactly the size that's needed, nothing more, nothing less. The size of the trampoline onion is still constrained by the size of the standard onion (1300 bytes).