Remove backwards-compatibility with 400-bytes payloads #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to keep creating 400-bytes trampoline payloads, as nobody is using eclair to _send_ trampoline payments, only to relay them, and at that stage it is backwards-compatible to support smaller and bigger onion sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to keep creating 400-bytes trampoline payloads, as nobody is using eclair to send trampoline payments, only to relay them, and at that stage it is backwards-compatible to support smaller and bigger onion sizes.
The diff seems large, but it actually mostly undoes some of the changes made in #2810: the diff with
masterwill end up smaller.NB: this PR targets the
variable-size-trampolinebranch used in #2810