Disable Trampoline-MPP to non-Phoenix recipients #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is safer for now since the splitting algorithm isn't working well on nodes with a large number of channels and we don't expect too many payments from Phoenix to non-Phoenix to actually need MPP in the short term.
pm47
approved these changes
Jan 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #1271 +/- ##
==========================================
+ Coverage 77.03% 77.08% +0.05%
==========================================
Files 142 142
Lines 9880 9873 -7
Branches 393 400 +7
==========================================
Hits 7611 7611
+ Misses 2269 2262 -7
|
t-bast
added a commit
that referenced
this pull request
Jan 17, 2020
Otherwise eclair-mobile can't pay using MPP. This heuristic was only here to help Trampoline nodes with a lot of channels relay using MPP, but we disabled that in #1271 anyway. We will reactivate Trampoline-MPP once split is done inside the router.
t-bast
added a commit
that referenced
this pull request
Jan 17, 2020
Otherwise eclair-mobile can't pay using MPP. This heuristic was only here to help Trampoline nodes with a lot of channels relay using MPP, but we disabled that in #1271 anyway. We will reactivate Trampoline-MPP once split is done inside the router.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is safer for now since the splitting algorithm isn't working
well on nodes with a large number of channels and we don't
expect too many payments from Phoenix to non-Phoenix to
actually need MPP in the short term.