Validate channel_announcement sigs early
#1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should validate the announcement signatures in the channel too. We still validate them in the router, but it's a different layer and the check should happen as soon as possible. We don't want to keep the channel open if the peer is sending us garbage.
It was called `ok` but was actually checking that it's *not* ok.
pm47
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to get these two simple fixes in the 0.4.0 release as well.
The first commit validates channel announcement signatures in the channel, before it reaches the router; it makes the flow a bit simpler. See the commit message for details.
The second commit is just a variable rename. The fact that it was called
okwas quite misleading to readers.