-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API commands to sign & verify arbitrary messages #1499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuskramer
force-pushed
the
feature/api-signmessage-verifymessage
branch
from
July 30, 2020 15:55
5c00653
to
defcc7d
Compare
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
t-bast
requested changes
Jul 31, 2020
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
t-bast
reviewed
Aug 6, 2020
eclair-core/src/main/scala/fr/acinq/eclair/crypto/KeyManager.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/crypto/LocalKeyManagerSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/crypto/LocalKeyManagerSpec.scala
Outdated
Show resolved
Hide resolved
eclair-node/src/main/scala/fr/acinq/eclair/api/ExtraDirectives.scala
Outdated
Show resolved
Hide resolved
eclair-node/src/main/scala/fr/acinq/eclair/api/FormParamExtractors.scala
Show resolved
Hide resolved
Signed-off-by: Donovan Jean <donovan@acinq.fr>
dariuskramer
force-pushed
the
feature/api-signmessage-verifymessage
branch
from
August 6, 2020 09:52
03a643d
to
5f53fd9
Compare
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
t-bast
reviewed
Aug 7, 2020
eclair-core/src/main/scala/fr/acinq/eclair/crypto/KeyManager.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
t-bast
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1496
End to End tests
Sign
by ->Verified
byHow to use the
signmessage
commandHow to use the
verifymessage
commandSignature format conversion
The signature we return are in hexadecimal format. Lnd & C-lightning use a zbase32 format. To convert from and to zbase32 you can use zbase32 and some basics Unix tools.
Hexadecimal to zbase32
zbase32 to Hexadecimal
Message format
We expect the
msg
argument, for both commands, to be a valid base64 string, to avoid issues with charset and encoding: