Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bolt 3 spec test vectors #1669

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Update bolt 3 spec test vectors #1669

merged 3 commits into from
Jun 22, 2021

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Jan 8, 2021

To match the latest changes from lightning/bolts#539 and lightning/bolts#852

@codecov-io
Copy link

Codecov Report

Merging #1669 (f1cf2ff) into master (b477d17) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1669      +/-   ##
==========================================
+ Coverage   85.94%   86.04%   +0.09%     
==========================================
  Files         151      151              
  Lines       11471    11471              
  Branches      505      505              
==========================================
+ Hits         9859     9870      +11     
+ Misses       1612     1601      -11     
Impacted Files Coverage Δ
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.06% <0.00%> (+0.08%) ⬆️
...nq/eclair/blockchain/electrum/ElectrumClient.scala 74.26% <0.00%> (+0.73%) ⬆️
...q/eclair/blockchain/electrum/ElectrumWatcher.scala 77.77% <0.00%> (+3.17%) ⬆️
...clair/blockchain/electrum/ElectrumClientPool.scala 82.79% <0.00%> (+4.30%) ⬆️

@t-bast t-bast marked this pull request as ready for review June 22, 2021 08:47
@t-bast t-bast requested a review from pm47 June 22, 2021 08:47
@codecov-commenter
Copy link

Codecov Report

Merging #1669 (a75b9d4) into master (bbfbad5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1669   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files         146      146           
  Lines       10994    10994           
  Branches      444      444           
=======================================
  Hits         9795     9795           
  Misses       1199     1199           
Impacted Files Coverage Δ
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 84.68% <0.00%> (-0.43%) ⬇️
.../acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala 96.87% <0.00%> (+0.78%) ⬆️

@t-bast t-bast merged commit afb1b41 into master Jun 22, 2021
@t-bast t-bast deleted the bolt3-test-vectors branch June 22, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants