Various improvements and fixes #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
- Coverage 89.39% 89.36% -0.04%
==========================================
Files 145 145
Lines 11034 11044 +10
Branches 456 476 +20
==========================================
+ Hits 9864 9869 +5
- Misses 1170 1175 +5
|
* Reduce log level for explorer API errors * Reduce log level for remote peer invalid open_channel
If there is already a pending HTLC settlement command in the DB, the post-restart handler should let the channel replay it instead of sending a conflicting command.
Sometimes lnd sends announcement_signatures before sending their channel reestablish. This is a minor spec violation, we can simply delay the message and handle it later (hopefully once we've received their reestablish).
Breez sometimes returns errors that we fail to parse. Unfortunately we didn't correctly log the shared secrets because the variable was shadowed, so we can't investigate further for now.
If we're unable to fetch the number of unconfirmed parents for a utxo, this shouldn't cause the global utxo check to fail. We log a warning and let operations continue to ensure the metric is updated.
We're seeing some instances of the following error in our logs: cannot parse returned error: class fr.acinq.eclair.wire.protocol.UnknownMessage cannot be cast to class fr.acinq.eclair.wire.protocol.ChannelUpdate Logging the bytes and shared secrets will let us investigate these.
There may be a race condition where a peer disconnect in the middle of a channel id assignment. In that case, we still want to record the up-to-date mapping.
t-bast
force-pushed
the
various-improvements
branch
from
bc70cbf
to
60655e5
Compare
pm47
reviewed
May 25, 2021
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/PostRestartHtlcCleaner.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/ZmqWatcher.scala
Outdated
Show resolved
Hide resolved
pm47
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains many small commits that fix various issues I found looking at our node's logs for the past month.
All commits are independent and should be reviewed separately; each commit description details what is improved/fixed.