Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json type hints on channel data #1824

Merged
merged 1 commit into from
May 25, 2021
Merged

Add json type hints on channel data #1824

merged 1 commit into from
May 25, 2021

Conversation

pm47
Copy link
Member

@pm47 pm47 commented May 25, 2021

This is particularly helpful when in OFFLINE state.

This is particularly helpful when in `OFFLINE` state.
@pm47 pm47 requested a review from t-bast May 25, 2021 14:55
@codecov-commenter
Copy link

Codecov Report

Merging #1824 (d6a6f26) into master (98cae45) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1824      +/-   ##
==========================================
- Coverage   89.39%   89.31%   -0.09%     
==========================================
  Files         145      145              
  Lines       11034    11034              
  Branches      456      456              
==========================================
- Hits         9864     9855       -9     
- Misses       1170     1179       +9     
Impacted Files Coverage Δ
...clair/blockchain/bitcoind/rpc/BatchingClient.scala 86.36% <0.00%> (-13.64%) ⬇️
...lockchain/bitcoind/rpc/ExtendedBitcoinClient.scala 92.85% <0.00%> (-3.58%) ⬇️
...in/scala/fr/acinq/eclair/channel/TxPublisher.scala 95.23% <0.00%> (-1.79%) ⬇️
...main/scala/fr/acinq/eclair/router/Validation.scala 90.76% <0.00%> (-1.54%) ⬇️
...c/main/scala/fr/acinq/eclair/channel/Channel.scala 86.41% <0.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 97.65% <0.00%> (+1.56%) ⬆️

@pm47 pm47 merged commit f829a2e into master May 25, 2021
@pm47 pm47 deleted the channel-data-type-json branch May 25, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants